Fixes bug where dynamic partition overwrite mode didn't work for ORC#7379
Merged
abellina merged 3 commits intoNVIDIA:branch-23.02from Dec 17, 2022
Merged
Fixes bug where dynamic partition overwrite mode didn't work for ORC#7379abellina merged 3 commits intoNVIDIA:branch-23.02from
abellina merged 3 commits intoNVIDIA:branch-23.02from
Conversation
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
Collaborator
Author
|
build |
tgravescs
reviewed
Dec 16, 2022
|
|
||
| val jobId = java.util.UUID.randomUUID().toString | ||
|
|
||
| val committerOutputPath = if (dynamicPartitionOverwrite) { |
Collaborator
There was a problem hiding this comment.
nit, might be nice to pull the comment over:
// For dynamic partition overwrite, FileOutputCommitter's output path is staging path, files
// will be renamed from staging path to final output path during commit job
tgravescs
previously approved these changes
Dec 16, 2022
Collaborator
Author
|
build |
jlowe
approved these changes
Dec 16, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7378
This issue prevented orc writes from succeeding when writing using dynamic partition overwrite mode, it was a miss from either the implementation time of
GpuInsertIntoHadoopFsRelationCommandor an update we missed as there was an associated spark bug fix.